[Discourse.ros.org] [Next Generation ROS] Issues about Migration Guide

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Discourse.ros.org] [Next Generation ROS] Issues about Migration Guide

Ahmed Ali via ros-users


Hi everyone,

I tested the example from the Migration Guide in my PC(win 10 x64, binary packages  installation) and found some issues.

cmake_minimum_required(VERSION 2.8.3) --> cmake_minimum_required(VERSION 3.5)
auto node = rclcpp::node::Node::make_shared("talker"); -->  auto node = rclcpp::Node::make_shared("talker");
rclcpp::rate::Rate loop_rate(10); --> rclcpp::Rate loop_rate(10);





---
[Visit Topic](https://discourse.ros.org/t/issues-about-migration-guide/3493/1) or reply to this email to respond.


If you do not want to receive messages from ros-users please use the unsubscribe link below. If you use the one above, you will stop all of ros-users from receiving updates.
______________________________________________________________________________
ros-users mailing list
[hidden email]
http://lists.ros.org/mailman/listinfo/ros-users
Unsubscribe: <http://lists.ros.org/mailman//options/ros-users>
Reply | Threaded
Open this post in threaded view
|

[Discourse.ros.org] [Next Generation ROS] Issues about Migration Guide

Ahmed Ali via ros-users


BTW, I'm not sure that rclcpp::Rate spins while it sleeps. It hasn't in times gone by. Generally, you will break things in ROS2 if you sleep instead of spin; your buffers will overflow, etc. We usually use the timeouts on the spin methods instead.





---
[Visit Topic](https://discourse.ros.org/t/issues-about-migration-guide/3493/2) or reply to this email to respond.


If you do not want to receive messages from ros-users please use the unsubscribe link below. If you use the one above, you will stop all of ros-users from receiving updates.
______________________________________________________________________________
ros-users mailing list
[hidden email]
http://lists.ros.org/mailman/listinfo/ros-users
Unsubscribe: <http://lists.ros.org/mailman//options/ros-users>
Reply | Threaded
Open this post in threaded view
|

[Discourse.ros.org] [Next Generation ROS] Issues about Migration Guide

Ahmed Ali via ros-users
In reply to this post by Ahmed Ali via ros-users


The [migration guide](https://github.com/ros2/ros2/wiki/Migration-Guide) is a wiki page. Please feel free to edit it and improve it where you see fit. It would be good to post a link to the diff here afterwards to make others aware of your change. Thanks.





---
[Visit Topic](https://discourse.ros.org/t/issues-about-migration-guide/3493/3) or reply to this email to respond.


If you do not want to receive messages from ros-users please use the unsubscribe link below. If you use the one above, you will stop all of ros-users from receiving updates.
______________________________________________________________________________
ros-users mailing list
[hidden email]
http://lists.ros.org/mailman/listinfo/ros-users
Unsubscribe: <http://lists.ros.org/mailman//options/ros-users>